Local API: Support extracting about information from YouTube's new about popup#4370
Merged
FreeTubeBot merged 2 commits intoFreeTubeApp:developmentfrom Dec 21, 2023
Merged
Conversation
absidue
changed the title
absidue
force-pushed
the
support-about-popup
branch
from
d579e6c to
ecf082a
Compare
Member
Author
|
Remember to run |
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
PR: dependencies
absidue
added
PR: dependencies
PikachuEXE
approved these changes
Dec 3, 2023
Member
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
I can view content in about tab for both channels
Off topic: I always use yarn && yarn dev to avoid library version issue
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 3, 2023
ChunkyProgrammer
approved these changes
Dec 21, 2023
github-actions
bot
removed
the
PR: waiting for review
absidue
added a commit
that referenced
this pull request
Feb 23, 2024
…out popup (#4370) * Support extracting about information from YouTube's new about popup * Update YouTube.js from 7.0.0 to 8.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local API: Support extracting about information from YouTube's new about popup
Pull Request Type
Description
This pull request adds support for extracting the about information from YouTube's new popup, I also added support for showing the number of videos that the channel has. Auto-generated game channels like the Minecraft one below, still use the old about tab.
This doesn't fix the missing information on the about tab when Invidious is selected as the backend, as that requires changes on their side, to parse and include it in their API response.
This pull request also updates YouTube.js from 7.0.0 to 8.0.0, it contains two breaking changes, but one is for the library view that only logged in users have and the other one is because YouTube removed the
Channelstab on the channel page, but we have "always" extracted the related channels from the home tab, so the breaking change doesn't affect us either.Testing
Gibi ASMR (has the new about popup)
https://www.youtube.com/channel/UCE6acMV3m35znLcf0JGNn7Q
Minecraft - Topic (has the old about tab)
https://www.youtube.com/channel/UCQvWX73GQygcwXOTSf_VDVg
Remember to run
yarn installafter checking out this branch, so that you get the YouTube.js update. You will also want to runyarn installagain after switching away from this branch, to downgrade YouTube.js again, otherwise you'll get errors because the development branch doesn't support the new about data structure.